reduced Tokenizer::isC() usage#5724
Merged
firewave merged 1 commit intocppcheck-opensource:mainfrom Mar 5, 2024
Merged
Conversation
Collaborator
Author
|
I have the same changes for This should also allow us to get rid of some references being passed around - maybe even getting rid of one of the various IMO we should also be passing the |
firewave
force-pushed
the
tokenizer-c
branch
3 times, most recently
from
05b773c to
2c9b09a
Compare
Collaborator
Author
|
Requires #5853 to be merged first. |
firewave
force-pushed
the
tokenizer-c
branch
2 times, most recently
from
a6c6b21 to
0412730
Compare
firewave
force-pushed
the
tokenizer-c
branch
from
0412730 to
0b6f733
Compare
firewave
force-pushed
the
tokenizer-c
branch
from
0b6f733 to
7abd2f3
Compare
firewave
force-pushed
the
tokenizer-c
branch
from
7abd2f3 to
5ab7085
Compare
Collaborator
Author
|
Almost a whole week (actually three months including the draft period) without any feedback - merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each
Token(should) be connected to aTokenList.Tokenizerjust encapsulates that so we have no need to check theTokenizerbut can simply ask theToken.Also if we have function calls we pass in a flag to tell it if it is C/C++ we can get rid of that flag and simply ask the
Token.